Do not add controls when it is empty. Fixed #17 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls is an empty array.
|
Can you add a test case for this change? |
RoryO
added a commit
that referenced
this pull request
Dec 5, 2011
…ect_type_id_139 Do not add controls when it is empty. Fixed #17
jrafanie
added a commit
to jrafanie/manageiq
that referenced
this pull request
Sep 4, 2014
https://bugzilla.redhat.com/show_bug.cgi?id=956833 net-ping at 1.5.3 required net-ldap at ~>0.2.2, so we need to upgrade net-ping also. See: ruby-ldap/ruby-net-ldap#18 In upgrading from 0.2.2 to latest, 0.7.0, the change we need is here: ruby-ldap/ruby-net-ldap@v0.2.2...v0.7.0#diff-724e0b3130dc49ca34eadc7c25d28b18R1647. We want to be able to compact any nil control_codes.
astratto
pushed a commit
to astratto/ruby-net-ldap
that referenced
this pull request
Dec 18, 2015
…orted_object_type_id_139 Do not add controls when it is empty. Fixed ruby-ldap#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some LDAP servers, such as ApacheDS, consider as invalid protocol, if controls
is an empty array.